Delete operation performs the store.delete twice

diggy · June 30, 2020, 7:10am

Moved from GitHub ristretto/170

When an item is deleted by cache.Del(key), we delete it from the store on the following line

dgraph-io/ristretto/blob/a093fe661329ba68a99a9c3a63674992355f40b1/cache.go#L248-L259


	// Delete immediately.
	c.store.Del(keyHash, conflictHash)
	// If we've set an item, it would be applied slightly later.
	// So we must push the same item to `setBuf` with the deletion flag.
	// This ensures that if a set is followed by a delete, it will be
	// applied in the correct order.
	c.setBuf <- &item{
		flag:     itemDelete,
		key:      keyHash,
		conflict: conflictHash,
	}
}

the same item is deleted again in the process() goroutine

github.com

dgraph-io/ristretto/blob/a093fe661329ba68a99a9c3a63674992355f40b1/cache.go#L331-L334


			case itemDelete:
				c.policy.Del(i.key) // Deals with metrics updates.
				c.store.Del(i.key, i.conflict)
			}

I don’t think there’s a major side-effect of doing this but we’re doing unnecessary work by deleting an already deleted key.

Topic		Replies	Views
Is there a way to find out how many items are in the cache? Ristretto kind:question	1	421	April 26, 2023
Add multidelete support Ristretto investigate , ristretto , kind:enhancement , priority:p2 , status:accepted	3	712	December 19, 2019
Set and read out directly one after the other brings empty results Ristretto	1	632	February 12, 2022
Question - Keys added and Keys evicted graphs are similar? Ristretto kind:question , ristretto	8	844	June 29, 2020
Document behavior on key (hash) collisions Ristretto	1	1130	December 26, 2021

Delete operation performs the store.delete twice

Related topics