GraphQL Update Endpoint @auth Feedback

Users GraphQL
1

Tell me if there is a better place to put this feedback, but I was just going through the docs for @auth in GraphQL mode and read:

Currently, Dgraph evaluates update rules before the mutation. Our auth support is still in beta and we may extend this for example to make the update rule an invariant of the mutation, or enforce pre and post conditions, or even allow custom logic to validate the update data.

I’m not sure that this is the latest status as this is very “in-development” at the moment as far as I understand, but I wanted to note that I think having a “pre-update validation” and a “post-update validation” for the auth rules makes a lot of sense. Maybe I’m late to the game and it’s already been done. :slight_smile:

Anyway, like the docs mentioned doing the validation either before or after has a big impact on what kind of validation you can do, and I think there are valid use-cases for both.

I think that being able to set when to run what validator would be very intuitive. For example, the possible options you would then have as a user would be:

  • Just set a before validator
  • Just set an after validator
  • Set a before validator and a separate after validator
  • Set a both or maybe beforeAndAfter validator that will be run before and after and serves as a convenience for when the validation is the same for both runs

Those are just my thoughts. :slight_smile: Tell me if I should put these in a GitHub issue instead.

3 Likes
2

Thanks for the feedback @zicklag. We are looking into supporting some post and pre hooks to the query. We’ll post more updates about this as we tackle this in the upcoming month.

2 Likes