Badger build failed for GOOS=linux,arm

duckybsd · August 6, 2020, 11:27am

What version of Go are you using (`go version`)?

$ go version
go version go1.14.6

What operating system are you using?

Windows

What version of Badger are you using?

v2

Does this issue reproduce with the latest master?

yes

Steps to Reproduce the issue

under windows, using cross-platform compile:
set GOOS=linux
set GOARCH=arm

What Badger options were set?

opt.ValueLogLoadingMode = options.FileIO

What did you do?

Try to build my application to an arm/Linux binary

What did you expect to see?

it compiled 4 weeks ago without any issues

What did you see instead?

…\github.com\dgraph-io\badger\value.go:50:5: constant 4294967295 overflows int

ahsan · August 6, 2020, 11:52am

Hey @duckybsd,

Thanks for filing the issue. Can you please confirm if you are using 32-bit windows?

ibrahim · August 6, 2020, 12:39pm

Badger build has been failing on 32 bit machines for a while and there is an open issue about it Fix badger builds on 32 bit machines .

As for this crash, this should be a simple change as this integer is overflowing on 32 bit machines

github.com

dgraph-io/badger/blob/3e067a54e5964bf7640c7d74fa92cd015f2a3fc8/value.go#L50



	"github.com/dgraph-io/badger/v2/options"
	"github.com/dgraph-io/badger/v2/pb"
	"github.com/dgraph-io/badger/v2/y"
	"github.com/pkg/errors"
	"golang.org/x/net/trace"
)

// maxVlogFileSize is the maximum size of the vlog file which can be created. Vlog Offset is of
// uint32, so limiting at max uint32.
var maxVlogFileSize = math.MaxUint32

// Values have their first byte being byteData or byteDelete. This helps us distinguish between
// a key that has never been seen and a key that has been explicitly deleted.
const (
	bitDelete                 byte = 1 << 0 // Set if the key has been deleted.
	bitValuePointer           byte = 1 << 1 // Set if the value is NOT stored directly next to key.
	bitDiscardEarlierVersions byte = 1 << 2 // Set if earlier versions can be discarded.
	// Set if item shouldn't be discarded via compactions (used by merge operator)
	bitMergeEntry byte = 1 << 3
	// The MSB 2 bits are for transactions.

We’re looking for contributions so feel free to send a PR.

duckybsd · August 7, 2020, 5:10am

I am using windows 10 64 bits and try to do a cross compile my application to Linux/arm 32 bits binary

Topic		Replies	Views
Build failure for GOOS=solaris,illumos,plan9 Badger	5	1170	January 4, 2021
Badger crashes on full disk Badger	4	1023	October 6, 2022
Large vlog file > 2Gb while setting 2 key value pairs Badger kind:bug	0	777	June 16, 2021
Cross compiling for GOARCH=arm int overflow Ristretto status:accepted , kind:bug , good-first-issue , ticket:created	5	1233	January 4, 2021
Badger compaction results in OOM and loss of data Badger	7	1565	November 21, 2020