Restoring a backup now require a backupId?

dmai · June 16, 2020, 12:48am

Allow backup ID to be passed to restore endpoint.

dgraph-io:master ← dgraph-io:martinmr/restore-id

opened 11:42PM - 14 Apr 20 UTC

The backup ID can now be passed to select a specific series of backups.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/dgraph/5208)   Docs Preview: [<img src="https://bl.ocks.org/prashant-shahi/raw/3a9f99bec84231cfe3c0e82cf883f159/0e588d908ad8c8b10958b87ebdd2ba68779ccf4f/dgraph.svg" height="34" align="absmiddle" alt="Dgraph Preview"/>](https://dgraph-713d7c5795-55297.surge.sh)

In PR #5208 the title says that Dgraph now allows backup IDs to be provided in the restore command.

When I don’t provide a backup ID, I get this error message:

Field RestoreInput.backupId of required type String! was not provided.

Why is the backupId a required argument? From the PR name, I’d think it means it’s optional.

cc @martinmr

martinmr · June 16, 2020, 6:38pm

Yes, I made the backupID field non optional although I don’t think that was intentional. I’ll open a ticket to revert that change.