LGalatin
June 9, 2020, 9:58pm
1
Documenting all the tests that we are going to run (automated or manual but not including unit tests) specific to 20.07 first Beta release. Please comment or add what else we need.
End to End test for Vault integration - Manual - Dgraph-1305
Flock Tests
Bank Tests
Upgrade with migration tool (for Dgraph Internal Type changes). Upgrade from 20.03 and 2.1 releases. Jira ticket for the migration task: Dgraph-1617
Limit testing (this will not get done before the first beta release). Dgraph-46
mrjn
June 9, 2020, 10:00pm
2
I’m making this public to devs.
MichelDiz
June 9, 2020, 10:59pm
3
@LGalatin do you know if the @ashishgoswami ’s changes in Facets format will be in 20.07 release? Or before.
@LGalatin @MichelDiz we still have issues with facets when used with @normalze in few cases. I will be fixing it and adding tests for it.
1 Like
LGalatin
June 25, 2020, 9:31pm
6
@ashishgoswami is this done?
I have fixed above issues. PRs are pending for reviews.
dgraph-io:release/v20.03 ← dgraph-io:ashish/v20.03-normalize
opened 10:56AM - 19 Jun 20 UTC
Fixes: #5241
Fixes: DGRAPH-1670
This PR is related to #5690. It issues with… facets response when facets are retrieved with
`@normalize` directive. Below two cases are covered:
1. Fixing facets response with uid/uid list predicates.
2. Fixing facets response with scalard list predicates.
<!--
Your title must be in the following format: topic(Area): Feature
Topic must be one of build|ci|docs|feat|fix|perf|refactor|chore|test
Sample Titles:
feat(Enterprise): Backups can now get credentials from IAM
fix(Query): Skipping floats that cannot be Marshalled in JSON
perf: [Breaking] json encoding is now 35% faster if SIMD is present
chore: all chores/tests will be excluded from the CHANGELOG
Please add a description with these things:
1. A good description explaining the problem and what you changed.
2. If it fixes any GitHub issues, say "Fixes #GitHubIssue".
3. If it corresponds to a Jira issue, say "Fixes DGRAPH-###".
4. If this is a breaking change, please put "[Breaking]" in the title. In the description, please put a note with exactly who these changes are breaking for.
-->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/dgraph/5691)
Docs Preview: [<img src="https://bl.ocks.org/prashant-shahi/raw/3a9f99bec84231cfe3c0e82cf883f159/0e588d908ad8c8b10958b87ebdd2ba68779ccf4f/dgraph.svg" height="34" align="absmiddle" alt="Dgraph Preview"/>](https://dgraph-a1433bdd39-71794.surge.sh)
dgraph-io:master ← dgraph-io:ashish/normalize-facets-tests
opened 10:55AM - 19 Jun 20 UTC
Fixes: https://github.com/dgraph-io/dgraph/issues/5241
Fixes: DGRAPH-1670
Th… is PR fixes issue with facets when it is retrieved in a query containing `@normalize` directive.
While forming `@normalize` response, we flatten a `fastJsonNode` and make its grand children,
direct children of it. This should be valid in all of cases except when `fastJsonNode` is parent of
facets nodes. For example consider below data:
```
<0x1> <name> "Alice" .
<0x1> <friend> "Bob" (from="college") .
<0x1> <friend> "Roman" (from="school") .
```
Also consider below query:
```
q(func: uid(0x1)) @normalize {
name: name
friend: friends @facets
}
```
Expected response is:
```
{
"data": {
"q": [
{
"name": "Alice",
"friends|from": {
"0": "college",
"1": "school"
},
"friends": [
"Bob",
"Roman"
]
}
]
}
}
```
But actual response is:
```
{
"data": {
"q": [
{
"0": "college",
"1": "school",
"friends": [
"Bob",
"Roman"
],
"name": "Alice"
}
]
}
}
```
Its happening because we are flattening facet parent node `friends|from` as well which have node
`"0"` and `"1"` as children.
We are solving it by having extra information in the node if it is a `facets parent`.
<!--
Your title must be in the following format: topic(Area): Feature
Topic must be one of build|ci|docs|feat|fix|perf|refactor|chore|test
Sample Titles:
feat(Enterprise): Backups can now get credentials from IAM
fix(Query): Skipping floats that cannot be Marshalled in JSON
perf: [Breaking] json encoding is now 35% faster if SIMD is present
chore: all chores/tests will be excluded from the CHANGELOG
Please add a description with these things:
1. A good description explaining the problem and what you changed.
2. If it fixes any GitHub issues, say "Fixes #GitHubIssue".
3. If it corresponds to a Jira issue, say "Fixes DGRAPH-###".
4. If this is a breaking change, please put "[Breaking]" in the title. In the description, please put a note with exactly who these changes are breaking for.
-->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/dgraph-io/dgraph/5690)
Docs Preview: [<img src="https://bl.ocks.org/prashant-shahi/raw/3a9f99bec84231cfe3c0e82cf883f159/0e588d908ad8c8b10958b87ebdd2ba68779ccf4f/dgraph.svg" height="34" align="absmiddle" alt="Dgraph Preview"/>](https://dgraph-b1667f4285-77312.surge.sh)
Paras
July 17, 2020, 5:16pm
8
Based on the proposed Changelog for 20.07.0, here are the tests to be done:
GraphQL
Ludicrous mode
Queries with val, expand, reverse index
Online Restore